add support for downloading files from example-data pyansys repo #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #330 +/- ##
==========================================
+ Coverage 80.18% 80.22% +0.03%
==========================================
Files 18 18
Lines 2544 2554 +10
Branches 448 438 -10
==========================================
+ Hits 2040 2049 +9
Misses 350 350
- Partials 154 155 +1
|
mfkrogh
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of the Ansys lab deployment, has been requested an API to download files from the ansys/example-data public repo, where all the other teams are storing files to be downloaded during the examples tutorials.
Since this is conceptually similar to what we are doing in load_example, I have split portion of the latter to create "download_pyansys_example" and use it in load_example.
download_pyansys_example will use by default the github location, while load_example will override it with our s3 bucket, and since it will download session files it still has got the code to deal with the session file loading.
In the docstrings I have provided an example, which I also included in one of the docker github tests
in ansys/example-data we haven't got yet "ensight" examples, but we can already take advantage of the many fluent/mechanical examples that are available